add comment about 'r' and 'p' relkind

Co-authored-by: Ryan Krage <[email protected]>
braintree · Sep 15, 2023 · 3d164e2 · 3d164e2
1 parent bf4407d
commit 3d164e2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/pg_ha_migrations/blocking_database_transactions.rb b/lib/pg_ha_migrations/blocking_database_transactions.rb
@@ -61,7 +61,7 @@ def self.find_blocking_transactions(minimum_transaction_age = "0 seconds")
             l.locktype != 'relation'
             OR (
                ns.nspname != 'pg_catalog'
-               AND c.relkind IN ('r', 'p')
+               AND c.relkind IN ('r', 'p') -- 'r' is a standard table; 'p' is a partition parent
             )
           )
           AND psa.xact_start < clock_timestamp() - ?::interval

diff --git a/spec/safe_statements_spec.rb b/spec/safe_statements_spec.rb
@@ -15,7 +15,7 @@ def locks_for_table(table, connection:)
       JOIN pg_class ON pg_locks.relation = pg_class.oid
       JOIN pg_namespace ON pg_class.relnamespace = pg_namespace.oid
       WHERE pid IS DISTINCT FROM pg_backend_pid()
-        AND pg_class.relkind IN ('r', 'p')
+        AND pg_class.relkind IN ('r', 'p') -- 'r' is a standard table; 'p' is a partition parent
         AND pg_class.relname = '#{table}'
         AND pg_namespace.nspname = '#{schema}'
     SQL