Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

[CHORE] Fix issue with line ending chars in .gitattributes #252

Merged
merged 2 commits into from
Dec 19, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Dec 18, 2018

When user has git core.autocrlf set to crlf on windows machines there are collisions between eslint-docs and prettier due to inconsistent line endings in md files.

fixes: #249

@uniqueiniquity

Copy link
Collaborator

@weirdpattern weirdpattern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just

* text eol=lf

?

@armano2
Copy link
Contributor Author

armano2 commented Dec 18, 2018

@weirdpattern we can do it, i don't see any binary files in project

@bradzacher what do you think?

@weirdpattern
Copy link
Collaborator

I think the text part excludes binary, for binaries you can use * binary...

@armano2
Copy link
Contributor Author

armano2 commented Dec 18, 2018

This attribute enables and controls end-of-line normalization. When a text file is normalized, its line endings are converted to LF in the repository.

https://git-scm.com/docs/gitattributes#_checking_out_and_checking_in

Well, basically, it's enforcing that file is going to be read as text file.

@weirdpattern
Copy link
Collaborator

Still think we should be fine.
As you said before, no binaries just yet in the repo

@armano2
Copy link
Contributor Author

armano2 commented Dec 18, 2018

@weirdpattern ok you convinced me, i changed it to * text eol=lf

@bradzacher bradzacher merged commit 6d72b00 into bradzacher:master Dec 19, 2018
@armano2 armano2 deleted the patch-1 branch December 19, 2018 02:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eslint-docs and prettier seem to disagree
5 participants