Skip to content
This repository was archived by the owner on Jun 15, 2020. It is now read-only.

fix: issue with preserving new line characters in read-rule #37

Merged
merged 3 commits into from
Dec 19, 2018
Merged

fix: issue with preserving new line characters in read-rule #37

merged 3 commits into from
Dec 19, 2018

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Dec 18, 2018 •
edited
Loading

@codecov
Copy link

codecov bot commented Dec 18, 2018 •
edited
Loading

Codecov Report

Merging #37 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   92.68%   92.77%   +0.08%     
==========================================
  Files           5        5              
  Lines          82       83       +1     
  Branches       19       20       +1     
==========================================
+ Hits           76       77       +1     
  Misses          5        5              
  Partials        1        1
Impacted Files Coverage Δ
src/actions/read-rule.js 76.92% <100%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f0fdb5...fa97c57. Read the comment docs.

@armano2 armano2 requested a review from j-f1 December 18, 2018 23:41
j-f1
j-f1 suggested changes Dec 19, 2018
View reviewed changes
Copy link
Owner

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A few small issues, but otherwise it looks good to me.

@armano2
Copy link
Collaborator Author

armano2 commented Dec 19, 2018

@j-f1 suggestions applied

@armano2 armano2 self-assigned this Dec 19, 2018
j-f1
j-f1 approved these changes Dec 19, 2018
View reviewed changes
Copy link
Owner

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@j-f1 j-f1 merged commit fa606fb into master Dec 19, 2018
@armano2 armano2 deleted the preserve-eol branch December 19, 2018 03:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j-f1 j-f1 j-f1 approved these changes

Assignees

@armano2 armano2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eslint-docs and prettier seem to disagree
2 participants
@armano2 @j-f1