-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] 모집 게시글 상세보기 페이지 마크업 #61
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
392000e
:recycle: refactor: my, notification 페이지명 lowerCamelCase로 변경
kong430 4552cff
:sparkles: feature: location, category, color 상수 및 타입 정의
kong430 4f13e4b
:sparkles: feature: category enum으로 정의
kong430 ec6f956
:sparkles: feature: ArticleTag 컴포넌트에서 color를 props로 받도록 변경
kong430 4c74058
:sparkles: feature: ArticleType과 ArticlePreviewType을 분리하여 정의
kong430 46f3ba9
:sparkles: feature: 모집 게시글 상세 페이지 마크업
kong430 962b05e
:recycle: refactor: export 문을 style 로직 앞으로 옮김
kong430 55e6a59
:recycle: refactor: util 폴더명 utils로 변경
kong430 c0b1ec6
:goal_net: chore: html 렌더링 TODO 주석 제거
kong430 f57a4de
:goal_net: chore: 리뷰 1차 반영
kong430 8959d08
:twisted_rightwards_arrows: merge: merge develop & conflict 해결
kong430 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,13 @@ | ||
enum ArticleStatus { | ||
PROGRESS = 'PROGRESS', | ||
SUCCEED = 'SUCCEED', | ||
FAIL = 'FAIL', | ||
} | ||
|
||
enum ArticleStatusKr { | ||
PROGRESS = '모집중', | ||
SUCCEED = '모집성공', | ||
FAIL = '모집중단', | ||
SUCCEED = '모집완료', | ||
FAIL = '모집증단', | ||
} | ||
|
||
export { ArticleStatus }; | ||
export { ArticleStatus, ArticleStatusKr }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
enum Category { | ||
STUDY = 'STUDY', | ||
PROJECT = 'PROJECT', | ||
COMPETITION = 'COMPETITION', | ||
MEAL = 'MEAL', | ||
ETC = 'ETC', | ||
} | ||
|
||
enum CategoryKr { | ||
STUDY = '스터디', | ||
PROJECT = '프로젝트', | ||
COMPETITION = '공모전', | ||
MEAL = '식사', | ||
ETC = '기타', | ||
} | ||
|
||
export { Category, CategoryKr }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,11 @@ | ||
const BADGE_COLORS = [ | ||
'cyan', | ||
'green', | ||
'yellow', | ||
'orange', | ||
'grape', | ||
'red', | ||
'indigo', | ||
'violet', | ||
'lime', | ||
'teal', | ||
]; | ||
import { ArticleStatus } from '@constants/article'; | ||
|
||
export { BADGE_COLORS }; | ||
const BADGE_COLORS = ['cyan', 'green', 'yellow', 'orange', 'grape', 'violet', 'teal', 'pink']; | ||
|
||
const STATUS_COLOR = { | ||
[ArticleStatus.PROGRESS]: 'lime', | ||
[ArticleStatus.SUCCEED]: 'indigo', | ||
[ArticleStatus.FAIL]: 'red', | ||
}; | ||
|
||
export { BADGE_COLORS, STATUS_COLOR }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
더미 데이터는 constants 폴더에 정의해놓고 사용하고 계시군요~ 좋은 것 같습니다