[Feature] 모집 게시글 상세보기 페이지 마크업 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
storybook link -> https://637c707cf24ecaa36bad2e45-kokpfqumhh.chromatic.com/ |
sxungchxn
reviewed
Nov 24, 2022
Comment on lines
+7
to
+26
| const dummyArticlePreview: ArticlePreviewType = { | ||
| id: 1, | ||
| title: '모집 테스트1', | ||
| location: { | ||
| id: 2, | ||
| name: Location.BUSAN, | ||
| }, | ||
| category: { | ||
| id: 1, | ||
| name: Category.STUDY, | ||
| }, | ||
| commentCount: 31, | ||
| scrapCount: 12, | ||
| thumbnail: 'https://avatars.githubusercontent.com/u/90585081?v=4', | ||
| maxCapacity: 5, | ||
| currentCapacity: 3, | ||
| status: ArticleStatus.PROGRESS, | ||
| createdAt: '2021-04-03T18:45:19Z', | ||
| }; | ||
|
|
There was a problem hiding this comment.
더미 데이터는 constants 폴더에 정의해놓고 사용하고 계시군요~ 좋은 것 같습니다
sxungchxn
reviewed
Nov 24, 2022
Comment on lines
+163
to
+174
| const ParticipantButton = styled.button` | ||
| display: flex; | ||
| gap: 4px; | ||
| padding: 0; | ||
| height: 1.7rem; | ||
| align-items: center; | ||
| border: none; | ||
| background-color: ${({ theme }) => theme.white}; | ||
| &:hover { | ||
| cursor: pointer; | ||
| } | ||
| `; |
There was a problem hiding this comment.
향후에 mantine의 Button 사용해서 구현해보는 것도 좋을 것 같습니다
sxungchxn
reviewed
Nov 24, 2022
| <Badge color={getBadgeColor(id)} size="sm"> | ||
| {content} | ||
| <Badge color={color} size={size} radius="sm"> | ||
| <BadgeContent>{content}</BadgeContent> |
There was a problem hiding this comment.
BadgeContent 라는 요소가 필요한 이유가 있을까요? 아니라면 바로 children으로 넣어주는게 더 좋아보여요
There was a problem hiding this comment.
텍스트 크기를 적용하려고 했던건데 빈 스타일이 됐네요! 제거하겠습니다~
username1103
approved these changes
Nov 24, 2022
Comment on lines
5
to
8
| /** | ||
| * 카테고리 id, 지역 id 등 뱃지 옵션의 id를 입력합니다. | ||
| * id를 통해 색상이 결정됩니다. | ||
| */ | ||
| id: number; | ||
| color: string; |
There was a problem hiding this comment.
상위 컴포넌트에서 id 값을 통해 컬러를 골라 전달해주도록 바뀐 게 맞을까요?
id에서 color로 바뀐 것 같은데 주석도 변경되어야할 것 같아요.
There was a problem hiding this comment.
어..? 분명 바꿨었던 것 같은데 꿈이었나봐요...
Article Tag Props description 수정, 불필요한 Wrapper Element 제거
|
#64 |
|
storybook link -> https://637c707cf24ecaa36bad2e45-hgxwwnpnbv.chromatic.com/ |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
체크 리스트
작업 내역
Location,Category관련 enum 및 interface 정의ArticleTag컴포넌트에서 color를 직접 받도록 변경utils/color.ts에 정의문제 상황과 해결
비고