-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't publish comments when no files is update #674
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
96cf5e7
fix: Don't publish comments when no files is update
benjaminParisel 259cff4
remove double quote
benjaminParisel 02e9426
typo
benjaminParisel d1dad26
chore: add an antora extension to log aggregated component
tbouffard aaf1a82
pattern: try to restric to pages
tbouffard a188efc
Revert "chore: add an antora extension to log aggregated component"
tbouffard 7355a4e
Merge branch 'master' into feat/remove_undefined_on_PR_preview_link
tbouffard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// Extension to print the component + version that will be processed | ||
// Inspired by https://antora.zulipchat.com/#narrow/stream/282405-tips-.F0.9F.92.A1/topic/Show.20all.20components.20and.20versions.20processed.20when.20building | ||
// And review with content of https://docs.antora.org/antora/latest/extend/extension-use-cases/#list-discovered-component-versions | ||
|
||
'use strict' | ||
|
||
module.exports.register = function () { | ||
// see https://github.com/pinojs/pino/blob/master/docs/api.md | ||
const logger = this.getLogger('bonita-log-aggregated-component'); | ||
|
||
this.once('contentAggregated', ({ contentAggregate }) => { | ||
logger.info('Discovered the following component versions') | ||
contentAggregate.forEach((bucket) => { | ||
logger.info(`name: ${bucket.name}, version: ${bucket.version}, files: ${bucket.files.length}`) | ||
if (logger.isLevelEnabled('debug')) { | ||
const sources = bucket.origins.map(({url, refname}) => ({url, refname})); | ||
logger.debug('sources: %o', sources); | ||
} | ||
}) | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: shouldn't we restrict to
modules/**/pages/**/*.adoc
to fully fix #534?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to try i think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, I am going to open a fake PR in the labs-doc repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commited in aaf1a82.
✔️ Tested in bonitasoft/bonita-labs-doc#152 (comment). The previous edit shows that the navbar files was previously listed. This is not the case anymore.