fix: Don't publish comments when no files is update #674
Conversation
|
♻️ PR Preview 7355a4e has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 7355a4e has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
The sources (providing the repository url and ref, several elements can be used) are only logged when the debug level is enabled to prevent from generating too many logs.
|
Put in draft until we remove the cherry-pick commit to validate the fix. |
| required: false | ||
| default: 'modules/**/*.adoc' | ||
| default: "modules/**/*.adoc" |
There was a problem hiding this comment.
question: shouldn't we restrict to modules/**/pages/**/*.adoc to fully fix #534?
There was a problem hiding this comment.
We need to try i think
There was a problem hiding this comment.
Fine, I am going to open a fake PR in the labs-doc repository.
There was a problem hiding this comment.
Commited in aaf1a82.
✔️ Tested in bonitasoft/bonita-labs-doc#152 (comment). The previous edit shows that the navbar files was previously listed. This is not the case anymore.
|
|
I am merging this PR and validate the change in the master branch by updating bonitasoft/bonita-labs-doc#152 |
Skip the Comments step when no file updates are detected.
Closes #534