Adding username as parameter for the redis authentication #65
Conversation
| if username != "" { | ||
| if _, err := c.Do("AUTH", password); err != nil { | ||
| c.Close() | ||
| return nil, err | ||
| } | ||
| } else { | ||
| if _, err := c.Do("AUTH", username, password); err != nil { | ||
| c.Close() | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
You switched the call in the condition:
- empty
usernamecalls the command using theusernamevariable - a non-empty
usernamecalls the command without using theusernamevariable
There was a problem hiding this comment.
Yes, sorry for the mistaken.
I don't think this PR will be accepted by the author.
The repo is inactive for such a long time.
There was a problem hiding this comment.
Besides, I suggest that using tcp link url to include username and database index is the trick to pass through this dilemma if your library is dependent on redistore.
There was a problem hiding this comment.
Yes, sorry for the mistaken.
I don't think this PR will be accepted by the author.
The repo is inactive for such a long time.
Yes, I am of the same opinion. Perhaps an authentik should use a different library than this one if we want to implement modern Redis features.
Intention
I am using Authentik which is using your library. There is an open ticket for settings the Redis username. Sadly the username is not set in this library. Without fixing that issuer here, it's impossible to fix it in Authentik. ^^"
Changes
Adding the username as optional parameter.
I hope the PR is looking good, I am not a go developer. Please let me know if something is wrong/missing.