Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add Support for non-default Redis username #6334

Conversation

kerkmann
Copy link

Details

Changes

New Features

  • Adding the environment AUTHENTIK_REDIS__USER which allows to set the redis username.

Breaking Changes

  • None. Not setting the environment will not cause any trouble.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

closes goauthentik#5348

This add support for settings the redis user as well.
@kerkmann kerkmann requested a review from a team as a code owner July 22, 2023 17:52
@kerkmann kerkmann requested review from BeryJu and removed request for a team July 22, 2023 17:52
@netlify
Copy link

netlify bot commented Jul 22, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 24057f0
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64bc174410926200080fa520
😎 Deploy Preview https://deploy-preview-6334--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kerkmann kerkmann marked this pull request as draft July 22, 2023 17:52
@kerkmann kerkmann changed the title Draft: Fix: Add Support for non-default Redis username Fix: Add Support for non-default Redis username Jul 22, 2023
@netlify
Copy link

netlify bot commented Jul 22, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 24057f0
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/64bc174454a39200081c766f
😎 Deploy Preview https://deploy-preview-6334--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karelkryda
Copy link

Hi,
it looks like the boj/redistore has been inactive for some time now from its owner and its maintainers. I found a mention of a migration from the boj/redistore repo to the rbcervilla/redisstore repo. Could this solve the problem with the missing Redis ACL implementation in authentik?

@BeryJu
Copy link
Member

BeryJu commented Sep 26, 2023

@kerkmann with #6988 merged, this should be possible now, do you want to rebase the PR on main or should I?

@kerkmann
Copy link
Author

@BeryJu would be nice if you could do it. I've not set up the entire dev stuff anymore for Authentik. ^^"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants