Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- switch to PHP 8.3 #373

Merged
merged 2 commits into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-and-lint-php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.2
php-version: 8.3
extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, pdo_pgsql, intl, gd
coverage: none

Expand Down
4 changes: 2 additions & 2 deletions app/Domain/BenefitsReportTimesheet.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ class BenefitsReportTimesheet implements WithTitle, WithHeadings, WithEvents, Wi
{
use RegistersEventListeners;

protected const ROW_HEIGHT = 70;
protected const COLUMN_WIDTH = 22;
protected const int ROW_HEIGHT = 70;
protected const int COLUMN_WIDTH = 22;

public function __construct(
protected BenefitsReport $report,
Expand Down
4 changes: 2 additions & 2 deletions app/Domain/Notifications/Channels.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@

class Channels
{
public const MAIL = "mail";
public const SLACK = "slack";
public const string MAIL = "mail";
public const string SLACK = "slack";
}
4 changes: 2 additions & 2 deletions app/Domain/PolishHolidaysRetriever.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

class PolishHolidaysRetriever
{
protected const PROVIDER_KEY = "Poland";
protected const LANG_KEY = "pl";
protected const string PROVIDER_KEY = "Poland";
protected const string LANG_KEY = "pl";

public function getForYearPeriod(YearPeriod $yearPeriod): Collection
{
Expand Down
6 changes: 3 additions & 3 deletions app/Domain/TimesheetPerUserSheet.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ class TimesheetPerUserSheet implements WithTitle, WithHeadings, WithEvents, With
{
use RegistersEventListeners;

protected const HOURS_PER_DAY = 8;
protected const START_HOUR = 8;
protected const END_HOUR = 16;
protected const int HOURS_PER_DAY = 8;
protected const int START_HOUR = 8;
protected const int END_HOUR = 16;

public function __construct(
protected User $user,
Expand Down
16 changes: 8 additions & 8 deletions app/Domain/VacationTypeConfigRetriever.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@

class VacationTypeConfigRetriever
{
public const KEY_TECHNICAL_APPROVAL = "technical_approval";
public const KEY_ADMINISTRATIVE_APPROVAL = "administrative_approval";
public const KEY_BILLABLE = "billable";
public const KEY_HAS_LIMIT = "has_limit";
public const KEY_AVAILABLE_FOR = "available_for";
public const KEY_IS_VACATION = "is_vacation";
public const KEY_DURING_NON_WORKDAYS = "during_non_workdays";
public const KEY_REQUEST_ALLOWED_FOR = "request_allowed_for";
public const string KEY_TECHNICAL_APPROVAL = "technical_approval";
public const string KEY_ADMINISTRATIVE_APPROVAL = "administrative_approval";
public const string KEY_BILLABLE = "billable";
public const string KEY_HAS_LIMIT = "has_limit";
public const string KEY_AVAILABLE_FOR = "available_for";
public const string KEY_IS_VACATION = "is_vacation";
public const string KEY_DURING_NON_WORKDAYS = "during_non_workdays";
public const string KEY_REQUEST_ALLOWED_FOR = "request_allowed_for";

public function __construct(
protected Repository $config,
Expand Down
2 changes: 1 addition & 1 deletion app/Eloquent/Helpers/YearPeriodRetriever.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class YearPeriodRetriever
{
public const SESSION_KEY = "selected_year_period";
public const string SESSION_KEY = "selected_year_period";

public function __construct(
protected Session $session,
Expand Down
32 changes: 16 additions & 16 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,36 +5,36 @@
"keywords": ["toby", "laravel", "hr"],
"license": "MIT",
"require": {
"php": "^8.2",
"php": "^8.3",
"ext-pdo": "*",
"ext-redis": "*",
"azuyalabs/yasumi": "^2.6.0",
"barryvdh/laravel-dompdf": "^2.0.1",
"doctrine/dbal": "^3.6.2",
"doctrine/dbal": "^3.7.2",
"fakerphp/faker": "^1.22.0",
"guzzlehttp/guzzle": "^7.7.0",
"inertiajs/inertia-laravel": "^0.6.9",
"laravel/framework": "^10.13.0",
"laravel/sanctum": "^3.2.5",
"laravel/socialite": "^5.6.2",
"laravel/telescope": "^4.14.4",
"inertiajs/inertia-laravel": "^0.6.11",
"laravel/framework": "^10.33.0",
"laravel/sanctum": "^3.3.2",
"laravel/socialite": "^5.10.0",
"laravel/telescope": "^4.17.2",
"laravel/tinker": "^2.8.1",
"maatwebsite/excel": "^3.1.48",
"maatwebsite/excel": "^3.1.50",
"phpoffice/phpword": "^1.1.0",
"rackbeat/laravel-ui-avatars": "^1.2",
"sentry/sentry-laravel": "^3.4.1",
"spatie/laravel-google-calendar": "^3.6.0",
"sentry/sentry-laravel": "^4.1.0",
"spatie/laravel-google-calendar": "^3.7.1",
"spatie/laravel-model-states": "^2.4.6",
"spatie/laravel-permission": "^5.11",
"spatie/laravel-permission": "^5.11.0",
"spatie/laravel-slack-slash-command": "^1.11.4"
},
"require-dev": {
"blumilksoftware/codestyle": "^2.4.0",
"laravel/dusk": "^7.7.1",
"blumilksoftware/codestyle": "^2.6.0",
"laravel/dusk": "^7.11.4",
"mockery/mockery": "^1.5.1",
"nunomaduro/collision": "^7.5.2",
"phpunit/phpunit": "^10.2.0",
"spatie/laravel-ignition": "^2.1.3"
"nunomaduro/collision": "^7.10.0",
"phpunit/phpunit": "^10.4.2",
"spatie/laravel-ignition": "^2.3.1"
},
"autoload": {
"psr-4": {
Expand Down
Loading