Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- switch to PHP 8.3 #373

Merged
merged 2 commits into from
Nov 29, 2023
Merged

- switch to PHP 8.3 #373

merged 2 commits into from
Nov 29, 2023

Conversation

krzysztofrewak
Copy link
Member

In this PR I switched application to the newest PHP version: 8.3. It includes:

  • bumping Dockerfile's PHP versions for development and production environments
  • composer dependencies bump
  • adding types for all constants in the codebase

Only things I couldn't bump are:

  • permission package, but there's a issue for that: Update permissions package #372
  • Xdebug stable version, but I decided we can go with that for now, as it's only for development use

Interesting thing:

  • tests on my machine on PHP8.3 went green in 105-110s; on 8.2 it was 145s

@krzysztofrewak krzysztofrewak requested a review from a team as a code owner November 28, 2023 09:21
@krzysztofrewak krzysztofrewak requested a review from a team November 28, 2023 09:56
@krzysztofrewak krzysztofrewak merged commit 9798f3d into main Nov 29, 2023
2 checks passed
@krzysztofrewak krzysztofrewak deleted the php83 branch November 29, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants