Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add perfomance check btwn master pr [2] #61

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Add perfomance check btwn master pr [2] #61

merged 3 commits into from
Nov 10, 2023

Conversation

RaulTrombin
Copy link
Member

@RaulTrombin RaulTrombin commented Nov 6, 2023 •
edited
Loading

We need:

@RaulTrombin RaulTrombin requested review from patrickelectric and joaoantoniocardoso and removed request for patrickelectric November 6, 2023 20:25
@RaulTrombin RaulTrombin mentioned this pull request Nov 7, 2023
Closed
@RaulTrombin RaulTrombin mentioned this pull request Nov 7, 2023
Closed
@RaulTrombin RaulTrombin force-pushed the benchmark_check2 branch 2 times, most recently from 89c8f0c to d6fa90c Compare November 8, 2023 00:27
@RaulTrombin RaulTrombin changed the title [WIP] Add perfomance check btwn master pr [2] Add perfomance check btwn master pr [2] Nov 8, 2023
@RaulTrombin RaulTrombin marked this pull request as ready for review November 8, 2023 00:28
@RaulTrombin RaulTrombin changed the title Add perfomance check btwn master pr [2] [WIP] Add perfomance check btwn master pr [2] Nov 8, 2023
@RaulTrombin RaulTrombin marked this pull request as draft November 8, 2023 02:50
@RaulTrombin RaulTrombin changed the title [WIP] Add perfomance check btwn master pr [2] Add perfomance check btwn master pr [2] Nov 8, 2023
@RaulTrombin RaulTrombin marked this pull request as ready for review November 8, 2023 02:56
@RaulTrombin
Copy link
Member Author

RaulTrombin commented Nov 8, 2023 •
edited
Loading

@patrickelectric We need to re-run the last master's action jobs.
It was missing tree on the new self-hosted device.

@RaulTrombin RaulTrombin force-pushed the benchmark_check2 branch 2 times, most recently from a524be9 to 7524c7b Compare November 8, 2023 13:45
@RaulTrombin
Copy link
Member Author

It works:
image

Next, removing delay test commit and waiting a review @patrickelectric .

@RaulTrombin
Copy link
Member Author

ping @patrickelectric

@patrickelectric
Copy link
Member

@RaulTrombin is this wip ?

@patrickelectric patrickelectric merged commit 6fa52ec into bluerobotics:master Nov 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

@joaoantoniocardoso joaoantoniocardoso Awaiting requested review from joaoantoniocardoso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaulTrombin @patrickelectric