Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make inspector use generics, rm associated types #1934

Merged
merged 15 commits into from
Dec 24, 2024
Merged

Conversation

rakita
Copy link
Member

@rakita rakita commented Dec 20, 2024

Prep for integration

Make inspectors use generics over associated types. It is easier to integrate that way

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Valgrind Results:

==4754== Cachegrind, a high-precision tracing profiler
==4754== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==4754== Using Valgrind-3.22.0 and LibVEX; rerun with -h for copyright info
==4754== Command: target/release/revme bench snailtracer
==4754== 
Running snailtracer example!
elapsed: 1.142217458s
==4754== 
==4754== I refs:        462,215,431

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #1934 will not alter performance

Comparing rakita/prep (741a864) with main (8dc2e2f)

Summary

✅ 8 untouched benchmarks

@rakita rakita merged commit d634f31 into main Dec 24, 2024
28 checks passed
@rakita rakita deleted the rakita/prep branch December 24, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant