Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump revm dec 2024 #246

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

chore: bump revm dec 2024 #246

wants to merge 15 commits into from

Conversation

rakita
Copy link
Contributor

@rakita rakita commented Dec 20, 2024

Revm integrated in lib. Repo uses to slightly modified Revm bluealloy/revm#1934

One thing missing, is_precompile need to be supported.
And examples need integration

@rakita rakita marked this pull request as draft December 20, 2024 13:34
@gakonst
Copy link
Member

gakonst commented Dec 23, 2024

As discussed would like to hold on merging until we've iterated on the revm api a bit as this is used in a bunch of places and want to be thoughtful about breakages

@rakita
Copy link
Contributor Author

rakita commented Dec 23, 2024

As discussed would like to hold on merging until we've iterated on the revm api a bit as this is used in a bunch of places and want to be thoughtful about breakages

Doing exactly that, and I have already accounted interfaces and usage patterns when refactoring Revm. Changes that simplify integration even more, are here: bluealloy/revm#1934

Present context allows us a lot simpler usage and it is easier to navigate.

Would assume this will not be merged until we have PR in Reth.

@rakita rakita marked this pull request as ready for review December 26, 2024 12:32
@rakita
Copy link
Contributor Author

rakita commented Dec 26, 2024

@mattsse this is now integrated.

We should wait for Reth integration before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants