[PM-10394] Add new item type ssh key #4575

quexten · 2024-08-01T15:35:14Z

🎟️ Tracking

Server: #4575
Add Item Type: bitwarden/clients#10360
Add SSH Agent: bitwarden/clients#10293
Add Import/Export: bitwarden/clients#10529

Jira: https://bitwarden.atlassian.net/browse/PM-10395

📔 Objective

Add server support for the new ssh key cipher type. This is mostly copy paste from the other cipher types, with the one exception that we are filtering out ssh keys for older clients, using SSHKeyCipherMinimumVersion. We will update this once we know which release ssh keys will be in.

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov · 2024-08-01T15:44:57Z

Codecov Report

Attention: Patch coverage is 29.16667% with 34 lines in your changes missing coverage. Please review.

Project coverage is 42.53%. Comparing base (50f7fa0) to head (bc50cf3).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/Api/Vault/Models/Request/CipherRequestModel.cs	6.25%	15 Missing ⚠️
src/Api/Vault/Models/CipherSSHKeyModel.cs	40.00%	6 Missing ⚠️
...c/Api/Vault/Models/Response/CipherResponseModel.cs	0.00%	6 Missing ⚠️
src/Core/Vault/Models/Data/CipherSSHKeyData.cs	0.00%	4 Missing ⚠️
src/Api/Vault/Controllers/SyncController.cs	75.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4575      +/-   ##
==========================================
- Coverage   42.54%   42.53%   -0.02%     
==========================================
  Files        1389     1391       +2     
  Lines       64745    64792      +47     
  Branches     5943     5945       +2     
==========================================
+ Hits        27548    27561      +13     
- Misses      35975    36008      +33     
- Partials     1222     1223       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-08-01T16:07:38Z

Checkmarx One – Scan Summary & Details – 8b17816a-e0c3-4c7a-8707-99a10fd7f974

New Issues

Issue	Source File / Package	Checkmarx Insight
Unpinned Actions Full Length Commit SHA	/repository-management.yml: 119	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/repository-management.yml: 104	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/repository-management.yml: 111	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/repository-management.yml: 60	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/repository-management.yml: 119	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/repository-management.yml: 111	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/repository-management.yml: 104	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/repository-management.yml: 60	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 105
	CSRF	/src/Billing/Controllers/RecoveryController.cs: 38
	CSRF	/src/Billing/Controllers/StripeController.cs: 164
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 237
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 685
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 263
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 361
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 469
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 344
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 839
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 712
	Unpinned Actions Full Length Commit SHA	/repository-management.yml: 147
	Unpinned Actions Full Length Commit SHA	/repository-management.yml: 154
	Unpinned Actions Full Length Commit SHA	/repository-management.yml: 162
	Unpinned Actions Full Length Commit SHA	/repository-management.yml: 97
	Unpinned Actions Full Length Commit SHA	/repository-management.yml: 147
	Unpinned Actions Full Length Commit SHA	/repository-management.yml: 97
	Unpinned Actions Full Length Commit SHA	/repository-management.yml: 162
	Unpinned Actions Full Length Commit SHA	/repository-management.yml: 154

rawkode · 2024-08-10T08:21:24Z

Very excited by this! Preparing to ditch 1Password as I type 🙂

quexten · 2024-08-16T12:24:14Z

Setting this to ready for review, but it will not be merged until all ssh of the ssh key features are ready.

github-actions · 2024-11-04T12:47:01Z

LaunchDarkly flag references

🔍 2 flags added or modified

Name	Key	Aliases found	Info
ssh agent	`ssh-agent`
SSH Key Vault Item	`ssh-key-vault-item`

* Add ssh key item type * Add fingerprint * Limit ssh key ciphers to new clients * Fix enc string length for 4096 bit rsa keys * Remove keyAlgorithm from ssh cipher * Add featureflag and exclude mobile from sync * Add ssh-agent flag

justspacedog · 2024-12-29T12:39:34Z

I tested the feature as a potential replacement for 1Password, but I encountered two issues:

I copied the SSH key to my clipboard and clicked the "Import Key from Clipboard" option after creating a new item. However, nothing happened.
Subsequently, I received an "An error occurred" message when syncing to my iOS devices.

Notably, all other devices and browser extensions worked fine, and the server logs showed the following response:

[INFO] (sync) GET /api/sync?<data..> => 200 OK

To restore syncing functionality, I had to manually delete the key from the Trash.

quexten · 2024-12-29T16:47:20Z

@justspacedog Could you please note: Your desktop version, your iOS version, and are you using a self-hosted server (if so which one at what version).

justspacedog · 2025-01-03T22:34:15Z

macOS: 2024.12.1
iOS: Version: 2024.12.0 (1740)
server: selfhosted vaultwarden latest (I know not official) as docker on a synology

quexten · 2025-01-04T14:45:34Z

@justspacedog Might be related to this PR in vaultwarden: dani-garcia/vaultwarden#5339

Add ssh key item type

0093725

quexten added the hold Hold this PR or item until later; DO NOT MERGE label Aug 1, 2024

quexten changed the title ~~[PM-10394] Add ssh key item type~~ [PM-10394] Add new item type ssh key Aug 1, 2024

Add fingerprint

cd5baf4

This was referenced Aug 2, 2024

Add support for ssh-key item-type quexten/goldwarden#272

Open

[PM-10395] Add new item type ssh key bitwarden/clients#10360

Merged

[PM-10098] SSH Agent & SSH Key creation for Bitwarden Desktop bitwarden/clients#10293

Merged

quexten added 2 commits August 8, 2024 15:14

Limit ssh key ciphers to new clients

ddec883

Fix enc string length for 4096 bit rsa keys

c755ec3

quexten mentioned this pull request Aug 13, 2024

Windows & Mac Support quexten/goldwarden#4

Open

25 tasks

Remove keyAlgorithm from ssh cipher

39ab9a7

quexten marked this pull request as ready for review August 16, 2024 12:25

quexten requested a review from a team as a code owner August 16, 2024 12:25

quexten requested a review from gbubemismith August 16, 2024 12:25

quexten removed the hold Hold this PR or item until later; DO NOT MERGE label Aug 21, 2024

Add featureflag and exclude mobile from sync

f582cf5

gbubemismith previously approved these changes Aug 29, 2024

View reviewed changes

quexten mentioned this pull request Oct 1, 2024

PM-10393 SSH keys bitwarden/clients#10825

Merged

lizard-boy mentioned this pull request Oct 19, 2024

[PM-10394] Add new item type ssh key grepdemos/server#52

Open

quexten mentioned this pull request Oct 21, 2024

SSH keys manager AChep/keyguard-app#640

Open

fedemkr mentioned this pull request Oct 30, 2024

[PM-10401] Implemented SSH Key type handling bitwarden/ios#1092

Merged

quexten added the ephemeral-environment label Nov 1, 2024

Merge branch 'main' into auth/pm-10394/ssh-keys

82ad7b8

quexten dismissed gbubemismith’s stale review via 82ad7b8 November 4, 2024 12:45

github-actions bot added the feature-flag label Nov 4, 2024

quexten removed the ephemeral-environment label Nov 4, 2024

Merge branch 'main' into auth/pm-10394/ssh-keys

dcdaeeb

quexten requested a review from gbubemismith November 4, 2024 19:21

quexten added 2 commits November 5, 2024 20:08

Add ssh-agent flag

428104b

Merge branch 'main' into auth/pm-10394/ssh-keys

bc50cf3

gbubemismith approved these changes Nov 5, 2024

View reviewed changes

quexten merged commit dae493d into main Nov 5, 2024
52 checks passed

quexten deleted the auth/pm-10394/ssh-keys branch November 5, 2024 19:25

icyleaf mentioned this pull request Dec 24, 2024

[Bitwarden Vault] ... raycast/extensions#15837

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PM-10394] Add new item type ssh key #4575

[PM-10394] Add new item type ssh key #4575

quexten commented Aug 1, 2024 •

edited

Loading

codecov bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

rawkode commented Aug 10, 2024

quexten commented Aug 16, 2024

github-actions bot commented Nov 4, 2024 •

edited

Loading

justspacedog commented Dec 29, 2024

quexten commented Dec 29, 2024

justspacedog commented Jan 3, 2025

quexten commented Jan 4, 2025

[PM-10394] Add new item type ssh key #4575

[PM-10394] Add new item type ssh key #4575

Conversation

quexten commented Aug 1, 2024 • edited Loading

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

codecov bot commented Aug 1, 2024 • edited Loading

Codecov Report

github-actions bot commented Aug 1, 2024 • edited Loading

New Issues

Fixed Issues

rawkode commented Aug 10, 2024

quexten commented Aug 16, 2024

github-actions bot commented Nov 4, 2024 • edited Loading

LaunchDarkly flag references

🔍 2 flags added or modified

justspacedog commented Dec 29, 2024

quexten commented Dec 29, 2024

justspacedog commented Jan 3, 2025

quexten commented Jan 4, 2025

quexten commented Aug 1, 2024 •

edited

Loading

codecov bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Nov 4, 2024 •

edited

Loading