PM-10393 SSH keys #10825
Merged
PM-10393 SSH keys #10825
+3,571
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement ssh-key cipher type * Fix linting * Fix edit and view components for ssh-keys on desktop * Fix tests * Remove ssh key type references * Remove add ssh key option * Fix typo * Add tests
* Add ssh key import export for bitwarden json * Remove key type from ssh key export
|
New Issues
|
…and view co… (#11046) * Add privatekey publickey and fingerprint to both add-edit and view components * Remove wrong a11y title * Fix testid
* Add ssh agent, generator & import * Move ssh agent code to bitwarden-russh crate * Remove generator component * Cleanup * Cleanup * Remove left over sshGenerator reference * Cleanup * Add documentation to sshkeyimportstatus * Fix outdated variable name * Update apps/desktop/src/platform/preload.ts Co-authored-by: Andreas Coroiu <[email protected]> * Rename renderersshagent * Rename MainSshAgentService * Improve clarity of 'id' variables being used * Improve clarity of 'id' variables being used * Update apps/desktop/src/vault/app/vault/add-edit.component.html Co-authored-by: Andreas Coroiu <[email protected]> * Fix outdated cipher/messageid names * Rename SSH to Ssh * Make agent syncing more reactive * Move constants to top of class * Make sshkey cipher filtering clearer * Add stricter equality check on ssh key unlock * Fix build and messages * Fix incorrect featureflag name * Replace anonymous async function with switchmap pipe * Fix build * Update apps/desktop/desktop_native/napi/src/lib.rs Co-authored-by: Andreas Coroiu <[email protected]> * Revert incorrectly renamed 'Ssh' usages to SSH * Run cargo fmt * Clean up ssh agent sock path logic * Cleanup and split to platform specific files * Small cleanup * Pull out generator and importer into core * Rename renderersshagentservice to sshagentservice * Rename cipheruuid to cipher_id * Drop ssh dependencies from napi crate * Clean up windows build * Small cleanup * Small cleanup * Cleanup * Add rxjs pipeline for agent services * [PM-12555] Pkcs8 sshkey import & general ssh key import tests (#11048) * Add pkcs8 import and tests * Add key type unsupported error * Remove unsupported formats * Remove code for unsupported formats * Fix encrypted pkcs8 import * Add ed25519 pkcs8 unencrypted test file * SSH agent rxjs tweaks (#11148) * feat: rewrite sshagent.signrequest as purely observable * feat: fail the request when unlock times out * chore: clean up, add some clarifying comments * chore: remove unused dependency * fix: result `undefined` crashing in NAPI -> Rust * Allow concurrent SSH requests in rust * Remove unwraps * Cleanup and add init service init call * Fix windows * Fix timeout behavior on locked vault --------- Co-authored-by: Andreas Coroiu <[email protected]>
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #10825 +/- ##
==========================================
- Coverage 33.62% 33.54% -0.08%
==========================================
Files 2825 2835 +10
Lines 88200 88578 +378
Branches 16800 16854 +54
==========================================
+ Hits 29655 29713 +58
- Misses 56223 56537 +314
- Partials 2322 2328 +6 ☔ View full report in Codecov by Sentry. |
quexten
requested review from
coroiu,
Jingo88 and
gbubemismith
and removed request for
Jingo88
djsmith85
previously approved these changes
Oct 1, 2024
coroiu
previously approved these changes
Oct 2, 2024
gbubemismith
previously approved these changes
Oct 2, 2024
quexten
dismissed stale reviews from gbubemismith, coroiu, and djsmith85
via
824aa13
|
Resolved merge conflicts. |
djsmith85
previously approved these changes
Oct 21, 2024
gbubemismith
previously approved these changes
Oct 22, 2024
quexten
dismissed stale reviews from gbubemismith, coroiu, and djsmith85
via
1d34ef4
|
Moving to draft until QA passed and merge conflicts are resolved, as to keep re-reviews low. |
* Move ssh agent behind feature flag * Add separate flag for ssh agent
* Fix error message for import of unsupported ssh keys * Use triple equals in add-edit component for ssh keys
|
Since the last approval, a bug found by QA was fixed and a feature flag added (the agent is now entirely feature flagged), and the PR's for this were reviewed and approved seperately. |
djsmith85
approved these changes
Nov 7, 2024
gbubemismith
approved these changes
Nov 7, 2024
coroiu
approved these changes
Nov 8, 2024
willmartian
reviewed
Nov 20, 2024
| @@ -106,6 +106,9 @@ export class VaultItemsComponent extends BaseVaultItemsComponent implements OnIn | |||
| case CipherType.SecureNote: | |||
| this.groupingTitle = this.i18nService.t("secureNotes"); | |||
| break; | |||
| case CipherType.SshKey: | |||
| this.groupingTitle = this.i18nService.t("sshKeys"); | |||
There was a problem hiding this comment.
@quexten Isn't doesn't look like this i18n key exists in browser's messages.json
There was a problem hiding this comment.
Thanks for catching it
There was a problem hiding this comment.
Of course, and ty for fixing it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10393
QA ticket:
https://bitwarden.atlassian.net/browse/PM-12729
(Server PR):
bitwarden/server#4575
📔 Objective
This PR merges the feature branch for SSH keys to main.
All individual commits (aside from rebases) have been previously reviewed and approved in their PR's; but they have not been QA tested. This PR will be QA tested
Creation of SSH keys is gated behind a feature flag; use of them is not.
Included are:
SSH key item type:
Import export:
SSH Agent:
Note
Ssh key generation UI support will come in a follow-up PR tracked here: #11232
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes