Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any Bitwarden actions to be pinned to non-hash values #330

Merged
merged 1 commit into from
Oct 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lint-workflow/lint.py
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ def lint(filename):
break

# If the step has a 'uses' key, check if actions are in supported actions list and also value hash, except bitwarden actions.
if "bitwarden/gh-actions" not in path:
if "bitwarden/" not in path:
try:
# Check if actions are in supported actions list.
if path not in supported_actions:
Expand Down Expand Up @@ -342,7 +342,7 @@ def lint(filename):
# If the step has a 'uses' key, check path for external workflow
path_list = path.split("/", 2)

if "bitwarden/gh-actions" in path and len(path_list) < 3:
if "bitwarden/" in path and len(path_list) < 3:
findings.append(
LintFinding(
f"Step {str(i)} of job key '{job_key}' does not have a valid action path. (missing name of the repository or workflow)",
Expand Down