Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any Bitwarden actions to be pinned to non-hash values #330

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

vgrassia
Copy link
Member

@vgrassia vgrassia commented Oct 2, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

This PR allows actions that are stored in any Bitwarden repository to be pinned to non-hash values.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Oct 2, 2024
@vgrassia vgrassia requested a review from a team as a code owner October 2, 2024 14:48
@vgrassia vgrassia merged commit d6235cf into main Oct 2, 2024
6 checks passed
@vgrassia vgrassia deleted the update-linter-for-bitwarden-actions branch October 2, 2024 15:03
Copy link

github-actions bot commented Oct 2, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ cf2eb5ee-55bc-48ba-ad0b-4f21c76928cb

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants