Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from Azure SQL Edge to native SQL Server #435

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

mzieniukbw
Copy link
Contributor

🎟️ Tracking

N/A

📔 Objective

Move from Azure SQL Edge to Microsoft SQL Server.
This is due to ARM platform problems on M1 macs for Azure SQL Edge. The database keeps crashing without any reason.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mzieniukbw mzieniukbw requested a review from a team as a code owner September 17, 2024 06:34
Copy link

github-actions bot commented Sep 17, 2024

Logo
Checkmarx One – Scan Summary & Detailsebf0317e-d921-44cf-b57b-756a7305f4c3

No New Or Fixed Issues Found

Copy link

cloudflare-workers-and-pages bot commented Sep 17, 2024

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a34a25d
Status: ✅  Deploy successful!
Preview URL: https://871bb9f1.contributing-docs.pages.dev
Branch Preview URL: https://km-move-to-native-sql-server.contributing-docs.pages.dev

View logs

@withinfocus
Copy link
Contributor

We don't do this though: https://github.com/bitwarden/server/blob/f72932bf2496e70776a5fb81f0d4734b3807da9d/dev/docker-compose.yml#L5

Can you share some logs, perhaps in our DBOps channel? I'd like to work with Microsoft instead of dropping Azure SQL Edge as it's a much smaller footprint.

@mzieniukbw
Copy link
Contributor Author

@withinfocus Azure SQL Edge for ARM is EOL and the bug seems to be on Microsoft image, only surfaced after linux kernel update on Docker Desktop, see more details here.
I think moving to Microsoft SQL Server is the only supported option onwards.
Also note, Azure SQL Edge on linux/amd64 platform have not been updated for a while, unclear if and when it will get the fix.

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzieniukbw mzieniukbw merged commit b129777 into main Sep 20, 2024
8 checks passed
@mzieniukbw mzieniukbw deleted the km/move-to-native-sql-server branch September 20, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants