Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-12740] Move CollectionAdminService to AC Team #11269

Merged
merged 12 commits into from
Oct 1, 2024

Merge branch 'main' into ac/ac-3062/clients-move-collectionadminservi…

e3c51d5
Select commit
Loading
Failed to load commit list.
Merged

[PM-12740] Move CollectionAdminService to AC Team #11269

Merge branch 'main' into ac/ac-3062/clients-move-collectionadminservi…
e3c51d5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 1, 2024 in 1s

33.22% (-0.03%) compared to 97a97c4

View this Pull Request on Codecov

33.22% (-0.03%) compared to 97a97c4

Details

Codecov Report

Attention: Patch coverage is 32.14286% with 19 lines in your changes missing coverage. Please review.

Project coverage is 33.22%. Comparing base (97a97c4) to head (e3c51d5).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ault/components/vault-items/vault-items.stories.ts 0.00% 2 Missing ⚠️
...ter/services/routed-vault-filter-bridge.service.ts 0.00% 2 Missing ⚠️
...min-console/organizations/core/views/group.view.ts 0.00% 1 Missing ⚠️
...organizations/core/views/organization-user.view.ts 0.00% 1 Missing ⚠️
...e/organizations/manage/group-add-edit.component.ts 0.00% 1 Missing ⚠️
...omponents/member-dialog/member-dialog.component.ts 0.00% 1 Missing ⚠️
...ole/organizations/settings/org-import.component.ts 0.00% 1 Missing ⚠️
...pp/tools/import/import-collection-admin.service.ts 0.00% 1 Missing ⚠️
...s/collection-dialog/collection-dialog.component.ts 0.00% 1 Missing ⚠️
...ents/vault-items/vault-collection-row.component.ts 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11269      +/-   ##
==========================================
- Coverage   33.25%   33.22%   -0.03%     
==========================================
  Files        2732     2728       -4     
  Lines       85545    85428     -117     
  Branches    16304    16281      -23     
==========================================
- Hits        28451    28387      -64     
+ Misses      54838    54791      -47     
+ Partials     2256     2250       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov