-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-12740] Move CollectionAdminService to AC Team #11269
[PM-12740] Move CollectionAdminService to AC Team #11269
Conversation
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11269 +/- ##
==========================================
- Coverage 33.25% 33.22% -0.03%
==========================================
Files 2732 2728 -4
Lines 85545 85428 -117
Branches 16304 16281 -23
==========================================
- Hits 28451 28387 -64
+ Misses 54838 54791 -47
+ Partials 2256 2250 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviews platform owned files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 Tools changes LGTM
…ve-collectionadminservice-to-ac-team
c66c8ca
Resolved conflicts :( |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12740
📔 Objective
Move
CollectionAdminService
and related files to AC Team ownership.This also moves it out of the
web
app and intolibs/admin-console/common
. This facilitates its likely reuse in other clients (particularly CLI) and also separates it from client-specific code. This also necessitated the creation of an abstract interface for it.The main change for most codeowners is updated import statements.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes