Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12740] Move CollectionAdminService to AC Team #11269

Merged

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Sep 26, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12740

📔 Objective

Move CollectionAdminService and related files to AC Team ownership.

This also moves it out of the web app and into libs/admin-console/common. This facilitates its likely reuse in other clients (particularly CLI) and also separates it from client-specific code. This also necessitated the creation of an abstract interface for it.

The main change for most codeowners is updated import statements.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@eliykat eliykat requested review from a team as code owners September 26, 2024 23:48
@eliykat eliykat marked this pull request as draft September 26, 2024 23:51
Copy link
Contributor

github-actions bot commented Sep 26, 2024

Logo
Checkmarx One – Scan Summary & Details2554244c-4608-4d41-934a-868b40262656

Fixed Issues

Severity Issue Source File / Package
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/popup/account-switching/current-account.component.ts: 35

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 32.14286% with 19 lines in your changes missing coverage. Please review.

Project coverage is 33.22%. Comparing base (97a97c4) to head (e3c51d5).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ault/components/vault-items/vault-items.stories.ts 0.00% 2 Missing ⚠️
...ter/services/routed-vault-filter-bridge.service.ts 0.00% 2 Missing ⚠️
...min-console/organizations/core/views/group.view.ts 0.00% 1 Missing ⚠️
...organizations/core/views/organization-user.view.ts 0.00% 1 Missing ⚠️
...e/organizations/manage/group-add-edit.component.ts 0.00% 1 Missing ⚠️
...omponents/member-dialog/member-dialog.component.ts 0.00% 1 Missing ⚠️
...ole/organizations/settings/org-import.component.ts 0.00% 1 Missing ⚠️
...pp/tools/import/import-collection-admin.service.ts 0.00% 1 Missing ⚠️
...s/collection-dialog/collection-dialog.component.ts 0.00% 1 Missing ⚠️
...ents/vault-items/vault-collection-row.component.ts 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11269      +/-   ##
==========================================
- Coverage   33.25%   33.22%   -0.03%     
==========================================
  Files        2732     2728       -4     
  Lines       85545    85428     -117     
  Branches    16304    16281      -23     
==========================================
- Hits        28451    28387      -64     
+ Misses      54838    54791      -47     
+ Partials     2256     2250       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliykat eliykat marked this pull request as ready for review September 27, 2024 00:41
@eliykat eliykat enabled auto-merge (squash) September 27, 2024 00:52
coroiu
coroiu previously approved these changes Sep 27, 2024
Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviews platform owned files

audreyality
audreyality previously approved these changes Sep 27, 2024
Copy link
Contributor

@audreyality audreyality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Tools changes LGTM

Jingo88
Jingo88 previously approved these changes Sep 30, 2024
@eliykat eliykat dismissed stale reviews from Jingo88, audreyality, and coroiu via c66c8ca October 1, 2024 03:40
@eliykat eliykat requested a review from Jingo88 October 1, 2024 03:52
@eliykat
Copy link
Member Author

eliykat commented Oct 1, 2024

Resolved conflicts :(

@eliykat eliykat merged commit 363acf5 into main Oct 1, 2024
66 checks passed
@eliykat eliykat deleted the ac/ac-3062/clients-move-collectionadminservice-to-ac-team branch October 1, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants