Remove dependency on JDK 17 HexFormat #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ByteArray, ByteUtils, and HexFormat classes to do it.
msgilligan
force-pushed
the
msgilligan/ByteArray-ByteUtils-HexFormat
branch
from
7294fe7
to
e7635a7
Compare
schildbach
approved these changes
Sep 3, 2024
| import java.util.Comparator; | ||
|
|
||
| /** | ||
| * |
| return ARRAY_UNSIGNED_COMPARATOR; | ||
| } | ||
|
|
||
| // In Java 9, this can be replaced with Arrays.compareUnsigned() |
There was a problem hiding this comment.
I assume you're planning for JDK 8? Otherweise you as per comment you could replace this.
There was a problem hiding this comment.
Yes, planning for JDK 8!
I think the duplication is ok, for now. But I envision the following strategy:
|
|
There are definitely a few things in here that need cleanup, but I'm going to merge and we can fix them later. |
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ByteArray, ByteUtils, and HexFormat classes to do it.