Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor spelling/grammar fixups in BIPs 372 and 381 #1720

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Minor spelling/grammar fixups in BIPs 372 and 381 #1720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1a3a06
Update bip-0372.mediawiki
HubertIGL Dec 17, 2024
d02146c
Update bip-0381.mediawiki
HubertIGL Dec 17, 2024
50f06e9
Update bip-0384.mediawiki
HubertIGL Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bip-0372.mediawiki
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ P2C tweaks commit to external data, some of which may represent certain value
(like in some sidechains, single-use-seal applications like RGB etc). Creation
of such outputs much allow hardware devices to understand the structure of such
extra-transaction data, which may be in different formats and constantly
involve. Thus, this should be addresses with a separate standards (or be a
evolve. Thus, this should be addressed with a separate standards (or be a
Copy link
Member

@jonatack jonatack Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While touching this paragraph, there are other fixups that can be made:

 The scope of this proposal is deliberately kept narrow; it addresses
 only spending of transaction outputs containing P2C tweaks - and does not
-addresses construction of a new P2C commitments or transactions containing them
+address construction of new P2C commitments or transactions containing them
 in their outputs.<ref>'''Why only spending of P2C tweaked outputs is covered'''
-P2C tweaks commit to external data, some of which may represent certain value
+P2C tweaks commit to external data, some of which may represent certain values
 (like in some sidechains, single-use-seal applications like RGB etc). Creation
-of such outputs much allow hardware devices to understand the structure of such
+of such outputs allows hardware devices to understand the structure of such
 extra-transaction data, which may be in different formats and constantly
-involve. Thus, this should be addresses with a separate standards (or be a
+involve. Thus, this should be addresses with a separate standard (or be
 vendor-based). The current proposal only touches the question of spending an
-output which contained previously created P2C commitment, which does not creates
-a new commitment and does not provides that kind of risk of extra-blockchain
-value loses.</ref>
+output that contained previously created P2C commitments, which does not create
+a new commitment and does not provide that kind of risk of extra-blockchain
+value losses.</ref>

vendor-based). The current proposal only touches the question of spending an
output which contained previously created P2C commitment, which does not creates
a new commitment and does not provides that kind of risk of extra-blockchain
Expand Down Expand Up @@ -181,7 +181,7 @@ TBD
Timestamping with Bitcoin.
<https://petertodd.org/2016/opentimestamps-announcement>
[4] Adam Back, Matt Corallo, Luke Dashjr, et al. Enabling Blockchain
Innovations with Pegged Sidechains (commit5620e43). Appenxix A.
Innovations with Pegged Sidechains (commit5620e43). Appendix A.
<https://blockstream.com/sidechains.pdf>;.
[5] Maxim Orlovsky, Rene Pickhardt, Federico Tenga, et al. Key
tweaking: collision- resistant elliptic curve-based commitments.
Expand Down
2 changes: 1 addition & 1 deletion bip-0381.mediawiki
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ Invalid descriptors

* <tt>pk()</tt> only accepts key expressions: <tt>pk(pk(03a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd))</tt>
* <tt>pkh()</tt> only accepts key expressions: <tt>pkh(pk(03a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd))</tt>
* <tt>sh()</tt> only acceps script expressions: <tt>sh(03a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd)</tt>
* <tt>sh()</tt> only accepts script expressions: <tt>sh(03a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd)</tt>
* <tt>sh()</tt> is top level only: <tt>sh(sh(pkh(03a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd)))</tt>
==Backwards Compatibility==
Expand Down
2 changes: 1 addition & 1 deletion bip-0384.mediawiki
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ Invalid descriptors
==Backwards Compatibility==

<tt>combo()</tt> descriptors use the format and general operation specified in [[bip-0380.mediawiki|380]].
As this is a wholly new descriptor, it is not compatible with any implementation.
As this is a wholly new descriptor, it is not compatible with any implementations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine in the singular form.

However the scripts produced are standard scripts so existing software are likely to be familiar with them.

==Reference Implementation==
Expand Down
Loading