Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor spelling/grammar fixups in BIPs 372 and 381 #1720

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

HubertIGL
Copy link

@HubertIGL HubertIGL commented Dec 17, 2024

Changes to bip-0372.mediawiki:

"involve" → "evolve"
Corrects word choice as "evolve" better describes the progressive development of standards

"addresses" → "addressed"
Fixes verb tense to match the passive voice construction

"Appenxix" → "Appendix"
Fixes misspelling of "Appendix"


Changes to bip-0381.mediawiki:

"acceps" → "accepts"
Fixes misspelling of "accepts"


Changes to bip-0384.mediawiki:

"implementation" → "implementations"
Changes to plural form as it refers to multiple possible implementations

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

@@ -121,7 +121,7 @@ P2C tweaks commit to external data, some of which may represent certain value
(like in some sidechains, single-use-seal applications like RGB etc). Creation
of such outputs much allow hardware devices to understand the structure of such
extra-transaction data, which may be in different formats and constantly
involve. Thus, this should be addresses with a separate standards (or be a
evolve. Thus, this should be addressed with a separate standards (or be a
Copy link
Member

@jonatack jonatack Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While touching this paragraph, there are other fixups that can be made:

 The scope of this proposal is deliberately kept narrow; it addresses
 only spending of transaction outputs containing P2C tweaks - and does not
-addresses construction of a new P2C commitments or transactions containing them
+address construction of new P2C commitments or transactions containing them
 in their outputs.<ref>'''Why only spending of P2C tweaked outputs is covered'''
-P2C tweaks commit to external data, some of which may represent certain value
+P2C tweaks commit to external data, some of which may represent certain values
 (like in some sidechains, single-use-seal applications like RGB etc). Creation
-of such outputs much allow hardware devices to understand the structure of such
+of such outputs allows hardware devices to understand the structure of such
 extra-transaction data, which may be in different formats and constantly
-involve. Thus, this should be addresses with a separate standards (or be a
+involve. Thus, this should be addresses with a separate standard (or be
 vendor-based). The current proposal only touches the question of spending an
-output which contained previously created P2C commitment, which does not creates
-a new commitment and does not provides that kind of risk of extra-blockchain
-value loses.</ref>
+output that contained previously created P2C commitments, which does not create
+a new commitment and does not provide that kind of risk of extra-blockchain
+value losses.</ref>

@@ -71,7 +71,7 @@ Invalid descriptors
==Backwards Compatibility==

<tt>combo()</tt> descriptors use the format and general operation specified in [[bip-0380.mediawiki|380]].
As this is a wholly new descriptor, it is not compatible with any implementation.
As this is a wholly new descriptor, it is not compatible with any implementations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine in the singular form.

@jonatack jonatack changed the title Fix Minor spelling/grammar fixups in BIPs 372 and 381 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants