Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Make CHECK enforce 1 instead of just "!= 0" #1481

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tests: Make CHECK enforce 1 instead of just "!= 0" #1481

wants to merge 2 commits into from

Commits on Jan 11, 2024

  1. tests: Make CHECK enforce 1 instead of just "!= 0" 

    This ensures that we don't omit the "== 1" in tests accidentally,
and thus also strengthens existing tests in which it has been omitted.

We want to check "== 1" in particular for the return values of API
functions, but it also makes sense in the case of internal functions.

If you really want to check "!= 0", you can still write it explicitly.
    @real-or-random
    real-or-random committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    8e5bd3b View commit details
    Browse the repository at this point in the history

  2. tests: Drop redundant "== 1" in CHECKs

    @real-or-random
    real-or-random committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    d9c1688 View commit details
    Browse the repository at this point in the history