tests: Make CHECK enforce 1 instead of just "!= 0" #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that we don't omit the "== 1" in tests accidentally, and thus also strengthens existing tests in which it has been omitted. We want to check "== 1" in particular for the return values of API functions, but it also makes sense in the case of internal functions. If you really want to check "!= 0", you can still write it explicitly.
This comment was marked as resolved.
This comment was marked as resolved.
|
Concept ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we don't omit the "== 1" in tests accidentally,
and thus also strengthens existing tests in which it has been omitted.
We want to check "== 1" in particular for the return values of API
functions, but it also makes sense in the case of internal functions.
If you really want to check "!= 0", you can still write it explicitly.
The second commit drops all the redundant "== 1"s. I tried to be careful to drop it only where it makes sense. Now,
git grep "== 1"shows only instances where the 1 is supposed to be an actual integer and not a boolean. Still, this touches many lines, so I can drop this commit if you think it's too intrusive.