-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up app setting definitions as objects #1456
Labels
Milestone
Comments
mikkonie
added
feature
Requested feature or enhancement
app: projectroles
Issue in the projectroles app
labels
Jul 16, 2024
mikkonie
added a commit
that referenced
this issue
Jan 6, 2025
mikkonie
changed the title
Set up app setting definitions as classes
Set up app setting definitions as objects
Jan 7, 2025
mikkonie
added a commit
that referenced
this issue
Jan 7, 2025
mikkonie
added a commit
that referenced
this issue
Jan 7, 2025
mikkonie
added a commit
that referenced
this issue
Jan 7, 2025
mikkonie
added a commit
that referenced
this issue
Jan 7, 2025
mikkonie
added a commit
that referenced
this issue
Jan 7, 2025
mikkonie
added a commit
that referenced
this issue
Jan 8, 2025
mikkonie
added a commit
that referenced
this issue
Jan 8, 2025
mikkonie
added a commit
that referenced
this issue
Jan 8, 2025
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
As with many return values of implementable plugin methods, expecting these as dictionaries offers a lot of chance for user error and ambiguity.
We should set up a class for app settings and expect definitions to take form of a list of objects instead of a dict.
This also allows us to place critical validation in the class
__init__()
to detect badly defined settings as early as possible.Providing app settings as a dict should be deprecated with warning in v1.1 and removed in v1.2.
Existing setting dicts within SODAR Core should be replaced with the class objects, of course.
Tasks
PluginAppSettingDef
class[Not editable on target sites]
label visibilitys_val
variabless_key
variablesPluginAppSettingDef
The text was updated successfully, but these errors were encountered: