update legacy definitions (#1456)

bihealth · Jan 7, 2025 · 8b778e5 · 8b778e5
1 parent 977e2ab
commit 8b778e5
Show file tree

Hide file tree

Showing 6 changed files with 312 additions and 297 deletions.
diff --git a/adminalerts/plugins.py b/adminalerts/plugins.py
@@ -5,7 +5,7 @@
 
 # Projectroles dependency
 from projectroles.models import SODAR_CONSTANTS
-from projectroles.plugins import SiteAppPluginPoint
+from projectroles.plugins import SiteAppPluginPoint, PluginAppSettingDef
 
 from adminalerts.models import AdminAlert
 from adminalerts.urls import urlpatterns
@@ -15,6 +15,21 @@
 APP_SETTING_SCOPE_USER = SODAR_CONSTANTS['APP_SETTING_SCOPE_USER']
 APP_SETTING_TYPE_BOOLEAN = SODAR_CONSTANTS['APP_SETTING_TYPE_BOOLEAN']
 
+# Local constants
+ADMINALERTS_APP_SETTINGS = [
+    PluginAppSettingDef(
+        name='notify_email_alert',
+        scope=APP_SETTING_SCOPE_USER,
+        type=APP_SETTING_TYPE_BOOLEAN,
+        default=True,
+        label='Receive email for admin alerts',
+        description=(
+            'Receive email for important administrator alerts regarding e.g. '
+            'site downtime.'
+        ),
+    )
+]
+
 
 class SiteAppPlugin(SiteAppPluginPoint):
     """Projectroles plugin for registering the app"""
@@ -28,22 +43,8 @@ class SiteAppPlugin(SiteAppPluginPoint):
     #: UI URLs
     urls = urlpatterns
 
-    # TODO: Refactor as PluginAppSettingDef objects
-    #: App settings definition
-    app_settings = {
-        'notify_email_alert': {
-            'scope': APP_SETTING_SCOPE_USER,
-            'type': APP_SETTING_TYPE_BOOLEAN,
-            'default': True,
-            'label': 'Receive email for admin alerts',
-            'description': (
-                'Receive email for important administrator alerts regarding '
-                'e.g. site downtime.'
-            ),
-            'user_modifiable': True,
-            'global': False,
-        }
-    }
+    #: App setting definitions
+    app_settings = ADMINALERTS_APP_SETTINGS
 
     #: Iconify icon
     icon = 'mdi:alert'