Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AppSettingAPI.get_global_value(), review usage #1533

Closed
mikkonie opened this issue Jan 6, 2025 · 2 comments
Closed

Remove AppSettingAPI.get_global_value(), review usage #1533

mikkonie opened this issue Jan 6, 2025 · 2 comments
Assignees
@mikkonie
Labels
app: projectroles Issue in the projectroles app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement
Milestone
v1.1.0

Comments

@mikkonie
Copy link
Collaborator

mikkonie commented Jan 6, 2025

The get_global_value() helper is no longer needed after doing #1394.

Also, its usage should be reviewed. It seems this is in some cases called on the setting value instead of the definition? That is completely wrong and probably causes some issues.
@mikkonie mikkonie added breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement app: projectroles Issue in the projectroles app labels Jan 6, 2025
@mikkonie mikkonie added this to the v1.1.0 milestone Jan 6, 2025
@mikkonie mikkonie self-assigned this Jan 6, 2025
@mikkonie
Copy link
Collaborator Author

mikkonie commented Jan 7, 2025

The method was in fact used correctly. My confusion was caused by the misleading naming of s_val for setting definitions when retrieved using .items(). I will refactor this away as part of #1456.

mikkonie added a commit that referenced this issue Jan 8, 2025
@mikkonie
remove get_global_value() helper (#1394, #1533)
9be43c2
@mikkonie
Copy link
Collaborator Author

mikkonie commented Jan 8, 2025

Done.

@mikkonie mikkonie closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
app: projectroles Issue in the projectroles app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@mikkonie