Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVDOCS-6025 [update]: Storefront Checkouts, update response schema #468

Merged
merged 21 commits into from
Sep 12, 2024

Conversation

bc-andreadao
Copy link
Collaborator

@bc-andreadao bc-andreadao commented Aug 22, 2024

DEVDOCS-6025

Relevant slack conversation https://bigcommerce.slack.com/archives/C0WC9CSJX/p1724366031941559

What changed?

Update schema for Storefront API's Checkout endpoints

  • added in missing fields (see the above slack conversation)
  • updated the examples to use those fields

The all the endpoints for Storefront Checkout have the same response (now reference the same response & example)

Release notes draft

Updated the response schemas for the Checkout endpoints of the REST Storefront API.

Anything else?

@bc-andreadao bc-andreadao marked this pull request as ready for review August 23, 2024 23:20
@bc-andreadao
Copy link
Collaborator Author

cc @bigcommerce/team-checkout

Copy link
Contributor

@valentindellangela valentindellangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove downloadFileUrls please, everything else LGTM.
Thank you for updating the doc 🙇

@bc-andreadao
Copy link
Collaborator Author

Thanks @valentindellangela , yes downloadFileUrls has been removed

Copy link
Collaborator

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @bc-andreadao
Glad you were able to combine the response files for all the endpoints.

@bc-andreadao bc-andreadao merged commit ba8e125 into main Sep 12, 2024
3 checks passed
@bc-andreadao bc-andreadao deleted the DEVDOCS-6025-checkout-sf branch September 12, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants