-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVDOCS-6104: Clarify the meaning of version field in the request/response of cart/checkout API #498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Lucki2501 I made some editorial updates. I removed passive voice. Let me know if you think the changes are okay or if they change the meaning.
7b4a316
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's good on the words itself, I'm just wondering if there is the way to extract this general field and every place just refer it.
@bc-shawnwang Yeah I agree, I also notice there's a lot of duplication. I'll leave it to the dev-docs team to restructure the yaml files. |
…ponse of cart/checkout API
Co-authored-by: Traci Porter <[email protected]>
7b4a316
to
90dd7bc
Compare
Thank you @bc-shawnwang, @valentindellangela and @animesh1987 . I would like to close this PR for now and think about how to better restructure this file to remove the duplication. I wasn't able to figure out how to do it quickly. I will need to think about it. |
@bc-traciporter My PR 468 restructures the storefront checkout yml file, so that endpoint would be taken cared of |
Co-authored-by: bc-andreadao <[email protected]>
Awesome @bc-andreadao |
DEVDOCS-6104
What changed?
version
field in the request/response of cart/checkout API so developers know what it can be used for.Release notes draft
N/A
ping @bigcommerce/team-checkout