-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] follow several recommendations from the Scientific Python Library Development Guide #58
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 92.40% 92.40%
=======================================
Files 11 11
Lines 487 487
=======================================
Hits 450 450
Misses 37 37
|
okay adding those extra options has raised some issues and revealed some very hacky things I did for good -
|
Oh I thought I was breaking things... OK will probably move the problematic things in a separate PR so that the things that are 'trivial' in this one can go through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can move the warnings into separate issues since they need fixing eventually
pyproject.toml
Outdated
markers = [ | ||
"smoke: smoke tests that will run on a downsampled real dataset (deselect with '-m \"not smoke\"')", | ||
] | ||
filterwarnings = ["error"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commenting this line out should do the trick for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
NMIND checklist #44 (comment)