Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] follow several recommendations from the Scientific Python Library Development Guide #58

Merged
merged 9 commits into from
Mar 25, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (0595d0c) to head (e37b96e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   92.40%   92.40%           
=======================================
  Files          11       11           
  Lines         487      487           
=======================================
  Hits          450      450           
  Misses         37       37           
Files Coverage Δ
giga_connectome/methods.py 100.00% <ø> (ø)
giga_connectome/utils.py 94.66% <ø> (ø)

@htwangtw
Copy link
Collaborator

htwangtw commented Dec 14, 2023

okay adding those extra options has raised some issues and revealed some very hacky things I did for good -

  • test_load_atlas_setting, test_generate_group_mask: i manually override the templateflow home to load customised atlas. this is not a typical use case of templateflow
  • test_calculate_intranetwork_correlation: we used the niftimasker to flatten label atlas (3D); solvable
  • test_get_bids_images: this is from a hack to force pybids to index fmriprep outputs, you are a better person to judge if i am doing the right thing here

@Remi-Gau
Copy link
Collaborator Author

Oh I thought I was breaking things... OK will probably move the problematic things in a separate PR so that the things that are 'trivial' in this one can go through

Copy link
Collaborator

@htwangtw htwangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move the warnings into separate issues since they need fixing eventually

pyproject.toml Outdated
markers = [
"smoke: smoke tests that will run on a downsampled real dataset (deselect with '-m \"not smoke\"')",
]
filterwarnings = ["error"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commenting this line out should do the trick for now.

Copy link
Collaborator

@htwangtw htwangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@Remi-Gau Remi-Gau merged commit 4f79846 into bids-apps:main Mar 25, 2024
15 checks passed
@Remi-Gau Remi-Gau deleted the scipy branch March 25, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants