Skip to content

Commit

Permalink
Merge pull request #58 from Remi-Gau/scipy
Browse files Browse the repository at this point in the history
[MAINT] follow several recommendations from the Scientific Python Library Development Guide
  • Loading branch information
Remi-Gau authored Mar 25, 2024
2 parents 0595d0c + e37b96e commit 4f79846
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,11 @@ jobs:
- name: Test with pytest - ignore smoke test.
if: ${{ !contains(needs.check_skip_flags.outputs.head-commit-message, 'full_test') }}
run: |
pytest -m "not smoke" --cov=giga_connectome --cov-report=xml --doctest-modules -v --pyargs giga_connectome
pytest -m "not smoke" --cov=giga_connectome --cov-report=xml --pyargs giga_connectome
- name: Full test - run all the test to generate accurate coverage report.
if: ${{ contains(needs.check_skip_flags.outputs.head-commit-message, 'full_test') }} || ${{ github.event.pull_request.merged }}
run: pytest --cov=giga_connectome --cov-report=xml --doctest-modules -v --pyargs giga_connectome
run: pytest --cov=giga_connectome --cov-report=xml --pyargs giga_connectome

- uses: codecov/codecov-action@v4
if: ${{ always() }}
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ repos:
- id: end-of-file-fixer
- id: check-yaml
- id: check-added-large-files
- repo: https://github.com/psf/black
- repo: https://github.com/psf/black-pre-commit-mirror
rev: 24.3.0
hooks:
- id: black
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: "2"
version: 2

build:
os: "ubuntu-22.04"
Expand Down
1 change: 0 additions & 1 deletion giga_connectome/methods.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ def generate_method_section(
average_correlation: bool,
analysis_level: bool,
) -> None:

env = Environment(
loader=FileSystemLoader(Path(__file__).parent),
autoescape=select_autoescape(),
Expand Down
2 changes: 1 addition & 1 deletion giga_connectome/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def get_bids_images(
root=bids_dir,
database_path=bids_dir,
validate=False,
derivatives=True,
derivatives=False,
reset_database=reindex_bids,
)

Expand Down
6 changes: 6 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ exclude = "giga_connectome/_version.py"
line_length = 79

[tool.pytest.ini_options]
minversion = "7"
log_cli_level = "INFO"
xfail_strict = true
testpaths = ["giga_connectome/tests"]
addopts = ["-ra", "--strict-config", "--strict-markers", "--doctest-modules", "-v"]
markers = [
"smoke: smoke tests that will run on a downsampled real dataset (deselect with '-m \"not smoke\"')",
]
# filterwarnings = ["error"]

0 comments on commit 4f79846

Please sign in to comment.