-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convenient way to add minimal plugins for a headless server #767
Conversation
I definitely think something like this would be useful. I want to move off of the "configure plugins in the constructor" pattern as much as possible in favor of "configuration resources" (ex: AssetServerSettings) to solve problems like what we're seeing here with ScheduleRunnerPlugin. I think the real fix here is to migrate ScheduleRunnerPlugin to the "configuration resource" pattern. |
I'm not super sold on adding another "helper method" like |
@cart -- ...and here I thought I was going to make a tiny little contribution today 😝
The current windows nightly seems to be unable to compile |
Reported the ICE for windows nightly at rust-lang/rust#78660 |
thanks! we might need to disable windows nightly builds in the interim. |
Upstream fix is out for review: rust-lang/rust#78663 |
Yeah I'm thinking we might as well make the hard |
@CleanCut I definitely have a use-case for this with the Bevy benchmark games. It was really annoying to take out the
👍 I'm a strong believer of breaking it early. |
Yeah the one thing im not super sold on is the |
Yeah, I think that's a good idea for headless. Maybe |
Yeah I thought about that too. But ScheduleRunner isn't "core" (CorePlugins should be a subset of DefaultPlugins imo). |
On that note something like |
BaseHeadlessPlugins Lol naming is hard. I'm also not super worried about needing the name MinimalPlugins for anything else, so we don't necessarily need to make the decision now. But if we can find a clearly better name today we might as well use it |
Maybe |
Yeah thats not a bad train of thought. Or maybe |
I'd be confused at what the difference is, though. Maybe Hmm, |
Haha yeah every alternative we've come up with has too many downsides. Lets just stick with MinimalPlugins for now. I guess @CleanCut was a step ahead of us 😄 |
😆 |
It might be useful to make a way for folks to easily run a minimal bit of bevy (think headless server, CI job, etc.).
In that context, would this be a good approach? I based the actual minimal bit of plugins on #739 (comment) My biggest concern is that the loop duration is hard-coded.
Is there a more ideal way to solve this problem? Maybe in a separate module+trait? Or just document how to do this? Something else?