Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presets for new AOS Cine Frames #494

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

ChrisRosser
Copy link
Contributor

@ChrisRosser ChrisRosser commented Nov 1, 2024

Hi Everyone,

I'm launching some new Cine frames over the next few days and wanted to create presets so that people find them easy to tune. The tunes should be in the same style as previous submissions.

Thank you in advance for taking a look over them and I stand ready to make any alterations needed to esnure they meet our high Betaflight standards!

Also if you have any suggestions to improve the tunes based on your experience that would be incredible also.

presets/4.5/filters/aos_rc/aos_cine20_filters.txt Outdated Show resolved Hide resolved
presets/4.5/filters/aos_rc/aos_cine30_filters.txt Outdated Show resolved Hide resolved
presets/4.5/filters/aos_rc/aos_cine35_filters.txt Outdated Show resolved Hide resolved
presets/4.5/filters/aos_rc/aos_cine40_filters.txt Outdated Show resolved Hide resolved
@limonspb
Copy link
Member

limonspb commented Nov 1, 2024

@ChrisRosser Can't comment on the tune parameters much, but looks good overall.
Please fix the minor typos, and padding for options here and there mentioned above.
New presets must be EXPERIMENTAL at first. But we are less strict about it now :)

Small problem:
if filter preset uses a slider or sliders, it's better to do simplified_tuning apply.

On a side note:
If you want, then filter options can be checked by default inside a tune preset.
Also sag compensation can be checked by default, since it goes under TUNE umbrella too (again, if you want to)
And if you are using simplified tuning sliders, you don't have to list all pid values. Unless you want to.

set motor_poles = 12 can be set without option, if you want, if it is applied together with filtering or if it's in the filter preset.

Oh and now we have fancy mutually exclusive option groups to use, for example for stuff like RC links where only one option can be selected.
Example:

#$ OPTION_GROUP BEGIN: (EXCLUSIVE) A Mutually Exclusive set of options
    #$ OPTION BEGIN (UNCHECKED): Option the first
        CLI payload strings
    #$ OPTION END
    #$ OPTION BEGIN (UNCHECKED): Other option that might conflict with the first
        CLI payload strings
    #$ OPTION END
#$ OPTION_GROUP END

(thanks to @Stampede10343)

@ChrisRosser
Copy link
Contributor Author

ChrisRosser commented Nov 4, 2024

@limonspb and @haslinghuis

Thank you for your review and suggestions. I have made all the suggested whitespace changes. All of these tunes are based on the Cine25 and Cine35 tunes which have been used in the community for over a year without any issues so I'm confident they will be safe for anyone in the community to use. I've also set the MM to 1.0 on the new tunes which should be very very safe (I'm running 1.5 MM on all my drones)👍

@limonspb
Copy link
Member

limonspb commented Nov 4, 2024

@limonspb and @haslinghuis

Thank you for your review and suggestions. I have made all the suggested whitespace changes. All of these tunes are based on the Cine25 and Cine35 tunes which have been used in the community for over a year without any issues so I'm confident they will be safe for anyone in the community to use. I've also set the MM to 1.0 on the new tunes which should be very very safe (I'm running 1.5 MM on all my drones)👍

Any reason you didn't use simplified_tuning apply in the filter settings?
This command sets the proper values for the active sliders only.

@ChrisRosser
Copy link
Contributor Author

@limonspb and @haslinghuis
Thank you for your review and suggestions. I have made all the suggested whitespace changes. All of these tunes are based on the Cine25 and Cine35 tunes which have been used in the community for over a year without any issues so I'm confident they will be safe for anyone in the community to use. I've also set the MM to 1.0 on the new tunes which should be very very safe (I'm running 1.5 MM on all my drones)👍

Any reason you didn't use simplified_tuning apply in the filter settings? This command sets the proper values for the active sliders only

No reason, I'll add that line.

@limonspb limonspb merged commit d70a432 into betaflight:master Nov 7, 2024
1 check passed
@ChrisRosser ChrisRosser deleted the aos-cine branch November 8, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants