GitHub action linkml docs #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test fix for permissions
jeff-cohere
reviewed
Mar 10, 2025
| @@ -1,14 +1,19 @@ | |||
| name: Auto-deployment of bertron-schema Documentation | |||
| on: | |||
| #pull_request: | |||
There was a problem hiding this comment.
Is it time to uncomment this so we can see how things work in CI?
eecavanna
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
LGTM! I left some suggestions:
- Uncomment lines as suggested by @jeff-cohere
- Remove extra whitespace character
Comment on lines
+3
to
+5
| #pull_request: | ||
| # branches: | ||
| # - main |
There was a problem hiding this comment.
I suggest uncommenting these lines and reformatting them to match the push block below.
Suggested change
| #pull_request: | |
| # branches: | |
| # - main | |
| pull_request: | |
| branches: [ main ] |
I don't know whether uncommenting this will cause the workflow to run in this PR (since the block does not exist on the main branch yet), but uncommenting it before merging this PR branch in will put it on the main branch so it can take effect for (at least) future PRs.
Co-authored-by: eecavanna <[email protected]>
| @@ -32,7 +37,7 @@ jobs: | |||
|
|
|||
| - name: Derive files from sources | |||
| run: | | |||
| make squeaky-clean all | |||
| make all | |||
There was a problem hiding this comment.
this isn't needed for making the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.