Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditionally include endpoint_urls in deployment dictionary #5195

Merged
merged 2 commits into from
Jan 23, 2025
+7 −2
Merged

fix: conditionally include endpoint_urls in deployment dictionary #5195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5543268
fix: conditionally include endpoint_urls in deployment dictionary
Haivilo Jan 23, 2025
d5b2fa6
ci: auto fixes from pre-commit.ci
pre-commit-ci[bot] Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/bentoml/_internal/cloud/deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,11 +442,10 @@ def is_dev(self) -> bool:
return self._schema.manifest is not None and self._schema.manifest.dev

def to_dict(self) -> dict[str, t.Any]:
return {
result = {
"name": self.name,
"bento": self.get_bento(refetch=False),
"cluster": self.cluster,
"endpoint_urls": self._urls if self._urls else None,
"admin_console": self.admin_console,
"created_at": self.created_at,
"created_by": self.created_by,
Expand All @@ -458,6 +457,12 @@ def to_dict(self) -> dict[str, t.Any]:
"status": self.get_status(refetch=False).to_dict(),
}

# Add "endpoint_urls" only if it's not None
if self._urls:
result["endpoint_urls"] = self._urls

return result

def to_yaml(self):
return yaml.dump(self.to_dict(), sort_keys=False)

Expand Down
Loading