Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditionally include endpoint_urls in deployment dictionary #5195

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

Haivilo
Copy link
Contributor

@Haivilo Haivilo commented Jan 23, 2025

What does this PR address?

Listing deployment does not have endpoint urls, only get deployment. We might want to ignore it to to avoid confusion, e.g., bentoml deployment list -o json should not have "endpoint_urls": null.

Another possibility is that we can also do it by deleting the key manually when -o json is used.

Fixes #(issue)

Before submitting:

@Haivilo Haivilo requested a review from a team as a code owner January 23, 2025 02:07
@Haivilo Haivilo requested review from larme and removed request for a team January 23, 2025 02:07
@Haivilo Haivilo requested review from frostming and removed request for larme January 23, 2025 02:08
@Haivilo Haivilo merged commit e802584 into bentoml:main Jan 23, 2025
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants