-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable SSO directories #63
base: next
Are you sure you want to change the base?
Conversation
Allows configuring SSO directories explicitly in addition to more sane defaults (discovering them from AWS SDK credentials/config file locations)
This would be very useful to me, as I usually keep AWS stuff in a directory scoped to a project using direnv and AWS SSO util kind of ignores that. |
I'm open to this, but I'd rather see it implemented on the AWS CLI (/botocore) instead, so that it's not specific to aws-sso-util. Could you open an issue/PR there first to see if they're open to it? A workaround like this in aws-sso-util would be the backup if they aren't. |
It also occurred to me that it may be dangerous to allow an environment variable to tell it where to put credentials. A bit like the redirect on an OAuth flow. I'll have to think more about that, seek some advice. |
While I agree it should be stored in
I'll take a look at viability of implementing it in botocore when i have some free time (most likely not in the next ~3 weeks). |
The AWS SDK generally has the capability for you to tell it where to get credentials that you've already stored (e.g., with |
You're right, AWS SDK does not store, only reads the credentials. |
FYI: looks like you already made a feature request to botocore boto/botocore#1923 ? |
boto/botocore#1923 is different. It's asking for the functionality of |
83aff0f
to
426b8a6
Compare
be306f9
to
9290b84
Compare
Allows configuring SSO directories explicitly in addition to more sane defaults (discovering them from AWS SDK credentials/config file locations).