Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO cache & credentials directories inside botocore? #2668

Closed
1 of 2 tasks
nazarewk opened this issue May 4, 2022 · 4 comments
Closed
1 of 2 tasks

SSO cache & credentials directories inside botocore? #2668

nazarewk opened this issue May 4, 2022 · 4 comments
Assignees
Labels
duplicate This issue is a duplicate. feature-request This issue requests a feature. sso

Comments

@nazarewk
Copy link

nazarewk commented May 4, 2022

Describe the feature

I did not research the details, but author of https://github.com/benkehoe/aws-sso-util suggested moving my functionality of configurable SSO directories benkehoe/aws-sso-util#63 into the botocore and on the first glance it looks like a good idea.

Will add more info when i have time.

Use Case

Currently most (probably all?) of the SSO/sessions code is using in-memory credentials, requiring new credentials to be fetched for every CLI/tool invocation. Storing those values locally for reuse would help a lot with tooling responsiveness.

Proposed Solution

This is already a part of https://github.com/benkehoe/aws-sso-util/blob/master/lib/aws_sso_lib/sso.py

Other Information

Such credentials & cache could probably use the secrets management system used by the machine (keychain, secret-service etc.) possibly through https://pypi.org/project/keyring/ instead of forcing dependent SSO projects to do so themselves, like:

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

any

Environment details (OS name and version, etc.)

any

@nazarewk nazarewk added feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged. labels May 4, 2022
@tim-finnigan
Copy link
Contributor

Hi @nazarewk thanks for the feature request. I think this overlaps with #1923. Have you read through the comments in that issue? If there are any distinctions between these two issues you would like to make please let us know.

@tim-finnigan tim-finnigan added response-requested Waiting on additional info and feedback. sso and removed needs-triage This issue or PR still needs to be triaged. labels May 5, 2022
@nazarewk
Copy link
Author

nazarewk commented May 6, 2022

looks like above feature-request indeed covers the case

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. label May 6, 2022
@tim-finnigan tim-finnigan self-assigned this May 6, 2022
@tim-finnigan tim-finnigan added the duplicate This issue is a duplicate. label May 6, 2022
@tim-finnigan
Copy link
Contributor

Ok thanks for confirming, I'll go ahead and close this issue but please 👍 or comment on #1923 if you have additional feedback.

@github-actions
Copy link

github-actions bot commented May 6, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue is a duplicate. feature-request This issue requests a feature. sso
Projects
None yet
Development

No branches or pull requests

2 participants