Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note warning about poetry shell being moved to plugin in v2.0.0 #843

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

Add note warning about poetry shell being moved to plugin in v2.0.0 #843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ setup:
# helm install beta9 deploy/charts/beta9 --create-namespace --values deploy/charts/beta9/values.local.yaml
kustomize build --enable-helm manifests/kustomize/overlays/cluster-dev | kubectl apply -f-

# Note: you may need https://github.com/python-poetry/poetry-plugin-shell as of poetry v2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we try doing something like poetry self add poetry-plugin-shell || true in this target? Assume its there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do that, but I'm not sure what will happen if the user has an old version still. Also, depending on how you installed poetry you might need to run something different.

setup-sdk:
curl -sSL https://install.python-poetry.org | python3 -
export PATH="$$HOME/.local/bin:$$PATH"
Expand Down
Loading