Add note warning about poetry shell being moved to plugin in v2.0.0 #843
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,6 +9,7 @@ setup: | |||
| # helm install beta9 deploy/charts/beta9 --create-namespace --values deploy/charts/beta9/values.local.yaml | |||
| kustomize build --enable-helm manifests/kustomize/overlays/cluster-dev | kubectl apply -f- | |||
|
|
|||
| # Note: you may need https://github.com/python-poetry/poetry-plugin-shell as of poetry v2.0.0 | |||
There was a problem hiding this comment.
What if we try doing something like poetry self add poetry-plugin-shell || true in this target? Assume its there?
There was a problem hiding this comment.
We could do that, but I'm not sure what will happen if the user has an old version still. Also, depending on how you installed poetry you might need to run something different.
nickpetrovic
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.