Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/KBDEV 1135 update NCIt loader with newer file formatting #131

Conversation

sshugsc
Copy link
Contributor

@sshugsc sshugsc commented Nov 24, 2023

update with newer file formatting according to https://evs.nci.nih.gov/ftp1/NCI_Thesaurus/ReadMe.txt

@@ -27,11 +28,12 @@ This is a headerless tab delimited file with the following
- display name
- concept status
- semantic type
- concept in subset
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept name also changed to concept IRI.

@@ -46,5 +48,5 @@ Then, after you have loaded the [FDA-SRS](../fdaSrs) data (if you are planning t
load the cross-reference mapping data

```bash
node bin/loadFile ncitFdaXref FDA-UNII_NCIt_Subsets.txt
node bin/load.js file ncitFdaXref FDA-UNII_NCIt_Subsets.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, that shows how old that loader is, lol!

This comment has been minimized.

@mathieulemieux mathieulemieux self-requested a review November 27, 2023 17:52
@sshugsc sshugsc merged commit a752031 into develop Nov 27, 2023

This comment has been minimized.

1 similar comment
Copy link

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a752031. ± Comparison against base commit b5bc480.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants