-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update startup/developer docs #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just wondering about leaving the user flag out, or maybe allowing an arg to specify it
@@ -6,6 +6,8 @@ else | |||
db="realm_registry" | |||
fi | |||
|
|||
echo "SELECT 'CREATE DATABASE $db' WHERE NOT EXISTS (SELECT FROM pg_database WHERE datname = '$db')\gexec" | psql -d postgres | |||
postgres_username=<<postgres_username>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, the only thing with this is this file isn't gitignored, so setting it in the file will potentially lead to us pushing over eachothers. IDK though this script is only for local so don't want to burn too much time on it. Maybe just explicitly setting to postgres is okay, or passing it in as a script arg
No description provided.