Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: #696 oc namespace config #697

Closed
wants to merge 23 commits into from
Closed

hotfix: #696 oc namespace config #697

wants to merge 23 commits into from

Conversation

craigyu
Copy link
Collaborator

@craigyu craigyu commented Sep 13, 2024 •
edited by github-actions bot
Loading

Update the pr-open.yml to have a specific environment defined

Thanks for the PR!

Any successful deployments (not always required) will be available below.

Once merged, code will be promoted and handed off to following workflow run.

@craigyu craigyu marked this pull request as draft September 13, 2024 20:10
@craigyu craigyu closed this Sep 13, 2024
@craigyu craigyu reopened this Sep 13, 2024
@craigyu craigyu marked this pull request as ready for review September 13, 2024 21:41
@craigyu craigyu requested a review from basilv September 13, 2024 22:03
basilv
basilv reviewed Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@basilv basilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this works because you are removing the OC_NAMESPACE repository variable and just leaving it as an environment variable, including for a new dev environment?

@craigyu
Copy link
Collaborator Author

craigyu commented Oct 2, 2024

I assume this works because you are removing the OC_NAMESPACE repository variable and just leaving it as an environment variable, including for a new dev environment?

That's exactly it

@craigyu craigyu linked an issue Oct 2, 2024 that may be closed by this pull request
Fix deployment script for environment OC_NAMESAPCE #696
Closed
@craigyu craigyu requested a review from basilv October 2, 2024 17:06
@DerekRoberts
Copy link
Member

DerekRoberts commented Oct 3, 2024 •
edited
Loading

@craigyu We probably don't need this PR anymore. I just removed the var completely! #701

@craigyu
Copy link
Collaborator Author

craigyu commented Oct 3, 2024

@craigyu We probably don't need this PR anymore. I just removed the var completely! #701

Looks like magic and a better solution to me

@craigyu
Copy link
Collaborator Author

craigyu commented Oct 3, 2024

done in #701

@craigyu craigyu closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianliuwk1019 ianliuwk1019 Awaiting requested review from ianliuwk1019

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts

@basilv basilv Awaiting requested review from basilv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix deployment script for environment OC_NAMESAPCE
3 participants
@craigyu @DerekRoberts @basilv