Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment script for environment OC_NAMESAPCE #696

Open
ianliuwk1019 opened this issue Sep 13, 2024 · 0 comments
Open

Fix deployment script for environment OC_NAMESAPCE #696

ianliuwk1019 opened this issue Sep 13, 2024 · 0 comments
Assignees
Labels
bug Something isn't working ❗ high high priority item 😵 unexpected

Comments

@ianliuwk1019
Copy link
Collaborator

ianliuwk1019 commented Sep 13, 2024

Describe the Bug
FOM production has a failure on Sept 13 for two batch jobs (workflow change/forest client refresh) and that caused business to report some FOM (ID: 1827) the status did not get changed to commenting open in the morning (batch job run) and still remained in PUBLISHED.

After team troubleshooting together, the discovery was both production and test environments all are pulling image from "-dev" space (from OC_NAMESPACE config).

The root cause was the recent PR change for the openshift deployment yml script to referencing the OC_NAMESPACE from Github environment/secret instead of previous hardcoded namespace value. This change did not work for TEST and PROD.
From the Github action environment/secret that there was still a default repository (${OC_NAMESPACE}) value and during deployment it seems the deployment(test/prod) all gets the (OC_NAMESPACE) value from the default repository value, although there were OC_NAMESPACE configured value setup in Github for other environments (-test/-prod).

Expected Behaviour
${OC_NAMESPACE} should referencing the correct value from environment specific.

Actual Behaviour
It was always the "dev" (the default one at the repository secret).

Action to take

  • Either revert back to previous configuration for using direct hardcode name space for each environment deployment at configuration, or get rid of Github repository (default) OC_NAMESPACE variable and add environment for -dev environment at openshift yaml to referencing the correct value from Github for all environments (dev/test/prod).

Additional context
Add any other context about the problem here.

@ianliuwk1019 ianliuwk1019 added bug Something isn't working ❗ high high priority item labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ❗ high high priority item 😵 unexpected
Projects
None yet
Development

No branches or pull requests

3 participants