fix: missing prod label for cronjob (among others?)

[DerekRoberts]

---

Thanks for the PR!

Any successful deployments (not always required) will be available below.

• api
• admin
• public

Once merged, code will be promoted and handed off to following workflow run.

• Main Merge Workflow

[MCatherine1994]

Hi Derek, just wondering are we still going to use "test" tag image in prod deployment? if we already promote image with tag "prod" in the previous step, maybe we can use the prod tag?

[DerekRoberts]

@MCatherine1994 No! That was a mistake. Thanks for the catch. :)

[MCatherine1994]

Hi Derek, just wondering in the openshift deployment yaml for the api, the cron job image is using image: ${REGISTRY}/${PROMOTE}, and the deployment config image is using image: ${NAME}-${ZONE}-${COMPONENT}:${ZONE}-api from image stream, I wonder shall we make them the same? or you'll have another pr for that?

[DerekRoberts]

@MCatherine1994 That's doable! I'd prefer to merge this and put the variable and image registry changes in another PR, since they're more of an improvement and less of a break/fix.

[DerekRoberts]

Rolled into #568. Closing.