Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add image consistency #567

Closed
DerekRoberts opened this issue Jan 17, 2024 · 2 comments · Fixed by #568
Closed

feat: add image consistency #567

DerekRoberts opened this issue Jan 17, 2024 · 2 comments · Fixed by #568
Assignees
Labels
enhancement New feature or request

Comments

@DerekRoberts
Copy link
Member

DerekRoberts commented Jan 17, 2024

API CronJob images are being pulled from GHCR, while the rest are imported into the OpenShift image registry first. Find a way to make them all consistent, ideally using OpenShift. That way we can keep an import of images for disaster-type deployments without GitHub.

Resolved in #568.

@DerekRoberts DerekRoberts added the enhancement New feature or request label Jan 17, 2024
@DerekRoberts DerekRoberts self-assigned this Jan 17, 2024
@DerekRoberts DerekRoberts moved this from New to Active in DevOps (NR) Jan 17, 2024
@MCatherine1994
Copy link
Contributor

MCatherine1994 commented Jan 17, 2024

Just add a question here,

So in the pr #564, we add "prod" tag to image every time after test deployment. And the plan in this ticket is to get both api and cronjob to pull the image directly from GHCR, with tag "prod". Then the api and cronjob could end up use latest "prod" tag image, even we haven't do prod deployment?

Maybe if pull from Openshift can solve the problem? Cause we only upload "prod" tag image to Openshift Prod image stream when doing prod deployment.

Thanks!

@DerekRoberts
Copy link
Member Author

@MCatherine1994 That's it and all safe! We have an upcoming ticket for image registry consistency intended to make this significantly less nonsensical. :P

@DerekRoberts DerekRoberts moved this from Active to Waiting in DevOps (NR) Jan 18, 2024
@github-project-automation github-project-automation bot moved this from Waiting to Done in DevOps (NR) Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants