Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for filter manifest files task #29

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Added tests for filter manifest files task #29

merged 5 commits into from
Aug 23, 2024

Conversation

mychal98
Copy link
Collaborator

@mychal98 mychal98 commented Nov 22, 2022 •
edited
Loading

Resolves #26

@mychal98 mychal98 added the type: test Improvement or additions to tests label Nov 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #29 (deecd0c) into main (77dfc63) will increase coverage by 5.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   21.57%   27.40%   +5.83%     
==========================================
  Files          31       31              
  Lines         343      343              
==========================================
+ Hits           74       94      +20     
+ Misses        269      249      -20
Impacted Files Coverage Δ
...ainer_collection/manifest/filter_manifest_files.py 96.55% <0.00%> (+68.96%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mychal98 mychal98 requested a review from cainja November 23, 2022 05:58
cainja
cainja requested changes Dec 6, 2022
View reviewed changes
tests/container_collection/manifest/test_filter_manifest_files.py Outdated
)
self.assertEqual(expected_selection, actual_selection)

def test_filter_manifest_files_include_B_exclude_0000(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should group these last two tests as subtests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two titles are hyper specific and don't really give much information about the API

@jessicasyu jessicasyu changed the title Added unit tests for filter_manifest_files task Added tests for filter manifest files task Aug 23, 2024
@jessicasyu jessicasyu merged commit 81acde5 into main Aug 23, 2024
5 checks passed
@jessicasyu jessicasyu deleted the test/filter_manifest_files branch August 23, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cainja cainja cainja requested changes

Assignees
No one assigned
Labels
type: test Improvement or additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for filter manifest files task
4 participants
@mychal98 @codecov-commenter @cainja @jessicasyu