Skip to content

Commit

Permalink
Fix type hints (#33)
Browse files Browse the repository at this point in the history
* FIx type hints in docker and fargate tasks

* Update pytest cov version
  • Loading branch information
jessicasyu authored Feb 15, 2023
1 parent 5a26f71 commit 8dd2ab6
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ isort = "^5.12.0"
mypy = "^0.971"
pylint = "^2.15.2"
pytest = "^7.2.0"
pytest-cov = "^3.0.0"
pytest-cov = "^4.0.0"
pytest-subtests = "^0.8.0"
Sphinx = "^5.1.1"
sphinx-rtd-theme = "^1.0.0"
Expand Down
2 changes: 1 addition & 1 deletion src/container_collection/docker/create_docker_volume.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@


@task
def create_docker_volume(path: int) -> docker.models.volumes.Volume:
def create_docker_volume(path: str) -> docker.models.volumes.Volume:
client = docker.DockerClient(base_url="unix://var/run/docker.sock")
volume = client.volumes.create(
driver="local", driver_opts={"type": "none", "device": path, "o": "bind"}
Expand Down
2 changes: 1 addition & 1 deletion src/container_collection/fargate/register_fargate_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@


@task
def register_fargate_task(task_definition: dict) -> None:
def register_fargate_task(task_definition: dict) -> str:
client = boto3.client("ecs")
response = client.list_task_definitions(familyPrefix=task_definition["family"])

Expand Down

0 comments on commit 8dd2ab6

Please sign in to comment.